Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to cmakeLists.txt to remove Mantid::DataHandling #38113

Closed
wants to merge 1 commit into from

Conversation

warunawickramasingha
Copy link
Contributor

@warunawickramasingha warunawickramasingha commented Oct 1, 2024

Description of work

This fix was added to not to import and reuse a method from Mantid::DataHandling library by linking with target_link_libraries in cmake which had caused some weird import errors on some Operating systems and to caused to miss some Crystal algorithms.

In this PR, the method that was required to be imported which was a only a small number of lines, was copied into RotateSampleShape class rather than reusing.

Further detail of work

To test:

The problem only appears when using a standalone installer, not a conda install (don't know why). This will give you a Windows installer until the full build_packages_from_branch can run for the other operating systems.
https://builds.mantidproject.org/job/build_packages_from_branch/908/

1- Follow the testing instructions as mentioned in #37908
2- Check for any startup errors or any missing Crystal libraries in different OSs specially on Linux

Release notes were not added since this is just an internal fix.


Reviewer

Please comment on the points listed below (full description).
Your comments will be used as part of the gatekeeper process, so please comment clearly on what you have checked during your review. If changes are made to the PR during the review process then your final comment will be the most important for gatekeepers. In this comment you should make it clear why any earlier review is still valid, or confirm that all requested changes have been addressed.

Code Review

  • Is the code of an acceptable quality?
  • Does the code conform to the coding standards?
  • Are the unit tests small and test the class in isolation?
  • If there is GUI work does it follow the GUI standards?
  • If there are changes in the release notes then do they describe the changes appropriately?
  • Do the release notes conform to the release notes guide?

Functional Tests

  • Do changes function as described? Add comments below that describe the tests performed?
  • Do the changes handle unexpected situations, e.g. bad input?
  • Has the relevant (user and developer) documentation been added/updated?

Does everything look good? Mark the review as Approve. A member of @mantidproject/gatekeepers will take care of it.

Gatekeeper

If you need to request changes to a PR then please add a comment and set the review status to "Request changes". This will stop the PR from showing up in the list for other gatekeepers.

@warunawickramasingha warunawickramasingha added this to the Release 6.11 milestone Oct 1, 2024
@warunawickramasingha warunawickramasingha added High Priority An issue or pull request that if not addressed is severe enough to postponse a release. Diffraction Issues and pull requests related to diffraction Single Crystal Issues and pull requests related to single crystal labels Oct 1, 2024
@warunawickramasingha warunawickramasingha changed the title Revert update to cmakeLists.txt to include Mantid::DataHandling Update to cmakeLists.txt to remove Mantid::DataHandling Oct 1, 2024
@warunawickramasingha warunawickramasingha changed the base branch from main to release-next October 1, 2024 09:49
@github-actions github-actions bot added the Has Conflicts Used by the bot to label pull requests that have conflicts label Oct 1, 2024
Copy link

github-actions bot commented Oct 1, 2024

👋 Hi, @warunawickramasingha,

Conflicts have been detected against the base branch. Please rebase your branch against the base branch.

@warunawickramasingha warunawickramasingha removed High Priority An issue or pull request that if not addressed is severe enough to postponse a release. Diffraction Issues and pull requests related to diffraction Single Crystal Issues and pull requests related to single crystal Has Conflicts Used by the bot to label pull requests that have conflicts labels Oct 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant