Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

(minor html display issue) <strong> tags in refs occasionally missing following space or line break #155

Closed
vincerubinetti opened this issue Jan 10, 2019 · 6 comments
Closed

(minor html display issue) <strong> tags in refs occasionally missing following space or line break #155

vincerubinetti opened this issue Jan 10, 2019 · 6 comments

Comments

@vincerubinetti
Copy link
Collaborator

vincerubinetti commented Jan 10, 2019 •
edited by dhimmel
Loading

See reference 30 in meta review for an example. In some of the references, the <strong> (bold) part is missing a space or line break after it. As far as I can tell, this is a pandoc issue. Nothing in the markup, ref json, etc seems to cause this.

Very minor issue, but I can include a simple javascript fix (modifying the generated html) in the other scripts being added (for tooltips, highlighting, etc).
@agitter
Copy link
Member

agitter commented Jan 10, 2019

@vincerubinetti good catch. Do you think this is worth reporting upstream with an issue in the pandoc repository?

@slochower
Copy link
Collaborator

I would suspect this is an issue in our custom CSL style. Probably worth uploading the CSL here (http://editor.citationstyles.org/visualEditor/) and seeing how it handles the website container type with a missing author.

@agitter
Copy link
Member

agitter commented Jan 10, 2019

@slochower that makes sense. I missed the fact that this problem was occurring within references. In that case, it does not need to be reported to pandoc.

@vincerubinetti
Copy link
Collaborator Author

vincerubinetti commented Jan 10, 2019 •
edited
Loading

Ah okay I'll look into the CSL style. I didn't check that one. Still getting used to how this whole manubot process is set up. Regardless, I already have an easy fix working that adds a new line after the <strong></strong> if it's not already there.

@vincerubinetti
Copy link
Collaborator Author

vincerubinetti commented Jan 10, 2019 •
edited
Loading

Yep, it's in the style.csl. I recommend changing <layout> to <layout delimiter=" "> to separate all the contained elements by a space, then change any first generation children to have spaceless prefixes/suffixes, eg <text variable="citation-number" suffix="."/>. I think that makes more sense for how the layout is intended to be.

I'd make a pr but not sure whether to do it in manubot-rootstock or meta-review or both.

@agitter
Copy link
Member

agitter commented Jan 10, 2019

I'd make a pr but not sure whether to do it in manubot-rootstock or meta-review or both.

Our general strategy for changes like this is to make the PR in manubot-rootstock. Then we periodically update meta-review and all other Manubot manuscripts to pull in the upstream changes (e.g. greenelab/meta-review#112).

@vincerubinetti vincerubinetti mentioned this issue Jan 18, 2019
Closed
@dhimmel dhimmel mentioned this issue Jun 7, 2020
Merged
cthoyt added a commit to chemical-roles/manuscript that referenced this issue Jun 30, 2020
@cthoyt @adam3smith
@rmzelle @vincerubinetti
Rootstock 2020 06 30 (#1)
8b87f49 
* CSL: add space delimiter across the style

merges manubot/rootstock#346
closes manubot/rootstock#155
supersedes manubot/rootstock#158
tested via manubot/manubot#110
refs https://twitter.com/csl_styles/status/1270049414200074243

Add a space delimiter across the style.
Fixes some references where there is a missing space after the title,
when authors are missing.

Set second-field-align="flush"
This option is not supported by pandoc yet, but it more closely resembles
hanging-indent="true", which pandoc is currently using to layout the
bibliography.

Co-authored-by: Rintze M. Zelle <[email protected]>

* Improve themes for DOCX output

merges manubot/rootstock#348
closes manubot/rootstock#344

Update docx files that can be supplied to Pandoc via --reference-doc.

Recreate build/themes/default.docx from scratch (via a blank pandoc output).
Improves aesthetic and fixes issues like invisible table gridlines.

Add build/themes/nih-grant.docx that produces documents that adhere
to many of the National Institutes of Health (NIH) formatting requirements.
https://grants.nih.gov/grants/how-to-apply-application-guide/format-and-write/format-attachments.htm

Co-authored-by: Sebastian Karcher <[email protected]>
Co-authored-by: Rintze M. Zelle <[email protected]>
Co-authored-by: Vincent Rubinetti <[email protected]>
ploegieku added a commit to ploegieku/2023-functional-homology-paper that referenced this issue Aug 6, 2024
@ploegieku @rmzelle
CSL: add space delimiter across the style
c980ce3 
merges manubot/rootstock#346
closes manubot/rootstock#155
supersedes manubot/rootstock#158
tested via manubot/manubot#110
refs https://twitter.com/csl_styles/status/1270049414200074243

Add a space delimiter across the style.
Fixes some references where there is a missing space after the title,
when authors are missing.

Set second-field-align="flush"
This option is not supported by pandoc yet, but it more closely resembles
hanging-indent="true", which pandoc is currently using to layout the
bibliography.

Co-authored-by: Rintze M. Zelle <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

CSL style: always add space after title
3 participants
@agitter @slochower @vincerubinetti