-
Notifications
You must be signed in to change notification settings - Fork 178
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upgrade manubot & environment on 2018-08-22 #132
Conversation
Running the following which uses the CSL style from 2a4a44a:
Produced the following:
Relates to discussion in manubot/manubot#45 and manubot/manubot#49 (comment) |
@agitter you possibly could try manubot.csl.txt... I added a conditional statement if Anyways, I am moving and shutting down my systems... so you'll have to proceed without me. |
Not going to get a chance to do more CSL work before returning. @agitter consider merging this. Perhaps would be good to have a bit more testing of the CSL changes, perhaps with the meta-review bibliography. Up to you whether to wait or proceed |
@dhimmel I'll review this once more and squash merge once I approve. I'll create a new issue regarding CSL, or add to our existing issue. Can you please remind me what I need to do for the squash commit message so that the issue doesn't appear in other downstream repositories? Do I include the full URL |
Just make sure not to have any relative github references... So yes use the full PR url in the message. The problem we want to avoid is this commit incorrectly linking to another PR in another repository |
This build is based on 3df864e. This commit was created by the following Travis CI build and job: https://travis-ci.org/greenelab/manubot-rootstock/builds/423103703 https://travis-ci.org/greenelab/manubot-rootstock/jobs/423103704 [ci skip] The full commit message that triggered this build is copied below: Upgrade manubot & environment on 2018-08-22 Merges #132 * Upgrade manubot to use process subcommand * Upgrade environment to latest versions on 2018-08-22 * CSL style: block to display identifiers
This build is based on 3df864e. This commit was created by the following Travis CI build and job: https://travis-ci.org/greenelab/manubot-rootstock/builds/423103703 https://travis-ci.org/greenelab/manubot-rootstock/jobs/423103704 [ci skip] The full commit message that triggered this build is copied below: Upgrade manubot & environment on 2018-08-22 Merges #132 * Upgrade manubot to use process subcommand * Upgrade environment to latest versions on 2018-08-22 * CSL style: block to display identifiers
Merges manubot/rootstock#132 * Upgrade manubot to use process subcommand * Upgrade environment to latest versions on 2018-08-22 * CSL style: block to display identifiers
Merges manubot/rootstock#132 * Upgrade manubot to use process subcommand * Upgrade environment to latest versions on 2018-08-22 * CSL style: block to display identifiers
Work in progress.