Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade manubot & environment on 2018-08-22 #132

Merged
merged 3 commits into from
Aug 31, 2018

Conversation

dhimmel
Copy link
Member

@dhimmel dhimmel commented Aug 22, 2018

Work in progress.

@dhimmel
Copy link
Member Author

dhimmel commented Aug 22, 2018

Running the following which uses the CSL style from 2a4a44a:

manubot cite --render \
  --csl=https://github.com/greenelab/manubot-rootstock/raw/2a4a44a5088e587aa25b9655f93842a264362038/build/assets/style.csl \
  doi:10.7554/eLife.32822 pmid:29424689 pmcid:PMC5832410 url:https://greenelab.github.io/meta-review/ 

Produced the following:

  1. Sci-Hub provides access to nearly all scholarly literature
    Daniel S Himmelstein, Ariel Rodriguez Romero, Jacob G Levernier, Thomas
    Anthony Munro, Stephen Reid McLaughlin, Bastian Greshake Tzovaras, Casey
    S Greene
    eLife (2018-03-01) https://doi.org/ckcj
    DOI: 10.7554/elife.32822 · PMID: 29424689 · PMCID: PMC5832410

  2. Sci-Hub provides access to nearly all scholarly literature.
    Daniel S Himmelstein, Ariel Rodriguez Romero, Jacob G Levernier, Thomas
    Anthony Munro, Stephen Reid McLaughlin, Bastian Greshake Tzovaras, Casey
    S Greene
    eLife (2018-03-01) https://www.ncbi.nlm.nih.gov/pubmed/29424689
    DOI: 10.7554/elife.32822 · PMID: 29424689 · PMCID: PMC5832410

  3. Sci-Hub provides access to nearly all scholarly literature
    Daniel S Himmelstein, Ariel Rodriguez Romero, Jacob G Levernier, Thomas
    Anthony Munro, Stephen Reid McLaughlin, Bastian Greshake Tzovaras, Casey
    S Greene
    eLife (2018) https://www.ncbi.nlm.nih.gov/pmc/articles/PMC5832410/
    DOI: 10.7554/elife.32822 · PMID: 29424689 · PMCID: PMC5832410

  4. Open collaborative writing with Manubot
    Daniel S. Himmelstein, David R. Slochower, Venkat S. Malladi, Casey S.
    Greene, Anthony Gitter
    (2018-08-03) https://greenelab.github.io/meta-review/

Relates to discussion in manubot/manubot#45 and manubot/manubot#49 (comment)

@dhimmel
Copy link
Member Author

dhimmel commented Aug 23, 2018

As long as you are editing the style, is it easy to add a default value when there is no author? I'll open a separate issue if it is out of scope.

@agitter you possibly could try manubot.csl.txt... I added a conditional statement if author is not present, but I don't think it necessarily will work.

Anyways, I am moving and shutting down my systems... so you'll have to proceed without me.

@dhimmel
Copy link
Member Author

dhimmel commented Aug 28, 2018

Not going to get a chance to do more CSL work before returning. @agitter consider merging this. Perhaps would be good to have a bit more testing of the CSL changes, perhaps with the meta-review bibliography. Up to you whether to wait or proceed

@agitter
Copy link
Member

agitter commented Aug 28, 2018

@dhimmel I'll review this once more and squash merge once I approve. I'll create a new issue regarding CSL, or add to our existing issue.

Can you please remind me what I need to do for the squash commit message so that the issue doesn't appear in other downstream repositories? Do I include the full URL https://github.com/greenelab/manubot-rootstock/pull/132?

@dhimmel
Copy link
Member Author

dhimmel commented Aug 28, 2018

Just make sure not to have any relative github references... So yes use the full PR url in the message. The problem we want to avoid is this commit incorrectly linking to another PR in another repository

@agitter agitter merged commit 3df864e into manubot:master Aug 31, 2018
dhimmel added a commit that referenced this pull request Aug 31, 2018
This build is based on
3df864e.

This commit was created by the following Travis CI build and job:
https://travis-ci.org/greenelab/manubot-rootstock/builds/423103703
https://travis-ci.org/greenelab/manubot-rootstock/jobs/423103704

[ci skip]

The full commit message that triggered this build is copied below:

Upgrade manubot & environment on 2018-08-22

Merges #132

* Upgrade manubot to use process subcommand

* Upgrade environment to latest versions on 2018-08-22

* CSL style: block to display identifiers
dhimmel added a commit that referenced this pull request Aug 31, 2018
This build is based on
3df864e.

This commit was created by the following Travis CI build and job:
https://travis-ci.org/greenelab/manubot-rootstock/builds/423103703
https://travis-ci.org/greenelab/manubot-rootstock/jobs/423103704

[ci skip]

The full commit message that triggered this build is copied below:

Upgrade manubot & environment on 2018-08-22

Merges #132

* Upgrade manubot to use process subcommand

* Upgrade environment to latest versions on 2018-08-22

* CSL style: block to display identifiers
@dhimmel dhimmel deleted the manubot-0.2-update branch September 19, 2018 15:19
adebali pushed a commit to CompGenomeLab/lemur-manuscript-archive that referenced this pull request Mar 4, 2020
Merges manubot/rootstock#132

* Upgrade manubot to use process subcommand

* Upgrade environment to latest versions on 2018-08-22

* CSL style: block to display identifiers
ploegieku added a commit to ploegieku/2023-functional-homology-paper that referenced this pull request Aug 6, 2024
Merges manubot/rootstock#132

* Upgrade manubot to use process subcommand

* Upgrade environment to latest versions on 2018-08-22

* CSL style: block to display identifiers
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants