Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix some hypothesis issues #345

Merged
merged 9 commits into from
Jun 5, 2020
Merged

fix some hypothesis issues #345

Changes from 1 commit
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
a93f2cf
fix some hypothesis issues
vincerubinetti Jun 5, 2020
ef35c6b
use canonical url for ann count lookup if available
vincerubinetti Jun 5, 2020
22dc412
update
vincerubinetti Jun 5, 2020
420b35c
update
vincerubinetti Jun 5, 2020
670f24d
hide hypothesis button on print
vincerubinetti Jun 5, 2020
4a355f6
add headings 5 and 6 to delete me
vincerubinetti Jun 5, 2020
5acd12b
remove print shrinking of h1 thru h3
vincerubinetti Jun 5, 2020
58eb7e9
incorp review comments
vincerubinetti Jun 5, 2020
b8d816c
update modified from comment
dhimmel Jun 5, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 4 additions & 3 deletions build/plugins/hypothesis.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -63,7 +63,8 @@
try {
const canonical = document.querySelector('link[rel="canonical"]');
const location = window.location;
const response = await fetch(query + (canonical || location).href);
const url = encodeURIComponent((canonical || location).href);
const response = await fetch(query + url);
const json = await response.json();
count = json.total || '-';
} catch(error) {
Expand Down Expand Up @@ -93,10 +94,10 @@

<template class="icon_hypothesis">
vincerubinetti marked this conversation as resolved.
Show resolved Hide resolved
<!-- modified from: https://fontawesome.com/icons/quote-right -->
dhimmel marked this conversation as resolved.
Show resolved Hide resolved
<svg width="16" height="16" viewBox="0 0 512 512" tabindex="-1">
<svg width="16" height="16" viewBox="0 0 24 24" tabindex="-1">
<path
fill="currentColor"
d="M464 32H336c-26.5 0-48 21.5-48 48v128c0 26.5 21.5 48 48 48h80v64c0 35.3-28.7 64-64 64h-8c-13.3 0-24 10.7-24 24v48c0 13.3 10.7 24 24 24h8c88.4 0 160-71.6 160-160V80c0-26.5-21.5-48-48-48zm-288 0H48C21.5 32 0 53.5 0 80v128c0 26.5 21.5 48 48 48h80v64c0 35.3-28.7 64-64 64h-8c-13.3 0-24 10.7-24 24v48c0 13.3 10.7 24 24 24h8c88.4 0 160-71.6 160-160V80c0-26.5-21.5-48-48-48z"
d="M3.43 0C2.5 0 1.72 .768 1.72 1.72V18.86C1.72 19.8 2.5 20.57 3.43 20.57H9.38L12 24L14.62 20.57H20.57C21.5 20.57 22.29 19.8 22.29 18.86V1.72C22.29 .77 21.5 0 20.57 0H3.43M5.14 3.43H7.72V9.43S8.58 7.72 10.28 7.72C12 7.72 13.74 8.57 13.74 11.24V17.14H11.16V12C11.16 10.61 10.28 10.07 9.43 10.29C8.57 10.5 7.72 11.41 7.72 13.29V17.14H5.14V3.43M18 13.72C18.95 13.72 19.72 14.5 19.72 15.42A1.71 1.71 0 0 1 18 17.13A1.71 1.71 0 0 1 16.29 15.42C16.29 14.5 17.05 13.71 18 13.71Z"
tabindex="-1"
></path>
</svg>
Expand Down