Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding RouteNamer interface #324

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

mikeschinkel
Copy link

Using api2go I noticed you coupled the types with the route names, and I want to have singular types and plural routes. So I added a RouteNamer interface. If you are willing to accept this I will be happy to update the docs too.

@wwwdata
Copy link
Member

wwwdata commented Mar 24, 2019

Thanks, LGTM but before we merge we should get the tests back to be running. I will look into this, merge it in and then you can rebase on master.

@wwwdata
Copy link
Member

wwwdata commented Mar 24, 2019

Ok, fixed the build problems in PR #325

What you could also do is add a small test to check that this functionality works so that we can guarantee that nothing breaks it in the future. Then we rebase after merging my PR and can merge this.

@wwwdata
Copy link
Member

wwwdata commented May 6, 2019

@mikeschinkel ping: would you like to continue here? otherwise I can also take over and merge after adding tests

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants