Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix GraphQL gen for enum lists #78

Merged
merged 5 commits into from
Dec 21, 2022
Merged

Fix GraphQL gen for enum lists #78

merged 5 commits into from
Dec 21, 2022

Conversation

Tenrys
Copy link
Contributor

@Tenrys Tenrys commented Dec 14, 2022

I tested it out, the generation seemed to work however I didn't try to see if the requests actually function properly.

Feel free to discard the extra commit, I was having a little bit of trouble setting up the project on my end.
I had to regenerate the .prisma folder as well because for some reason I had an issue while attempting to build the project, Prisma was missing.

@vercel
Copy link

vercel bot commented Dec 14, 2022

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Ignored Deployment
Name Status Preview Updated
prisma-appsync ⬜️ Ignored (Inspect) Dec 21, 2022 at 1:02AM (UTC)

@Tenrys Tenrys marked this pull request as ready for review December 14, 2022 12:36
@maoosi maoosi added this to the 1.0.0-rc.4 milestone Dec 20, 2022
@maoosi maoosi added is: bug Something isn't working package: generator Generator package labels Dec 20, 2022
@maoosi
Copy link
Owner

maoosi commented Dec 21, 2022

@Tenrys Thanks a lot for the PR! Will merge and release as part of 1.0.0-rc.4.

  • Prisma-AppSync is using pnpm (see https://prisma-appsync.vercel.app/contributing.html). So I’ve removed the yarn-related changes.
  • After investigating the issue, I realised the issue was affecting multiple list types (not only enums). So I’ve adapted your fix accordingly.

@all-contributors please add @Tenrys for code!

@allcontributors
Copy link
Contributor

@maoosi

I couldn't determine any contributions to add, did you specify any contributions?
Please make sure to use valid contribution names.

I've put up a pull request to add @Tenrys! 🎉

@maoosi maoosi merged commit 73ccfa0 into maoosi:main Dec 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
is: bug Something isn't working package: generator Generator package
Projects
Status: Released
Development

Successfully merging this pull request may close these issues.

2 participants