Skip to content
This repository has been archived by the owner on Dec 13, 2018. It is now read-only.

[wip] Expose watching functionality via npm #118

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Conversation

emilymcafee
Copy link
Contributor

Beginning to mold conex watching functionality to follow stork's example. Started by rewriting watch.sh in javascript.

const conex = require('@mapbox/ecs-conex').watch;

const options = {
  region: 'us-east-1',
  suffix: 'production',
  token: 'xxx',
  org: 'mapbox',
  repo: 'repo'
};

conex(options)
  .then(() => {
    console.log('mapbox/repo being watched by ecs-conex-production in us-east-1');
  });

Todo:

  • Decide if we want to write a "watch" lambda function, that a user can run with encrypted Github credentials saved in the environment instead of needing to store those credentials locally.
  • Tests \o/
  • Adjust linting + test scripts to catch correct files.
  • Decide if we want to deprecate bash functionality that does the same.
  • Docs, changelog, etc
  • Publish an npm module so that a user invoke the watch script (lambda or not) in javascript.

Would love a gutcheck from @rclark before I head down this path ☝️

@rclark
Copy link
Contributor

rclark commented Feb 3, 2018

Decide if we want to write a "watch" lambda function

Let's only do this if a Github App is not allowed to add webhooks. Hopefully it is, and any tools we write can use credentials from that app.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants