Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update readme and add home #283

Merged
merged 16 commits into from
Jan 2, 2017
Merged

update readme and add home #283

merged 16 commits into from
Jan 2, 2017

Conversation

YunjieLi
Copy link
Contributor

@YunjieLi YunjieLi commented Aug 19, 2016

  1. Update readme.md to include instructions for updating layout
  2. Add home/house icon (#281).
  3. Add Buddhist icon

@@ -1,21 +0,0 @@
Changelog
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like this was an accidental change.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's because I reverted a version I think

@samanpwbb
Copy link
Contributor

The basic form looks good. Some of your nodes are not quite pixel aligned. I recommend making sure you have a pixel grid set up in illustrator that places a gridline at every pixel (or even every half pixel), and make sure snap to grid Ctrl + Shft + ' is turned on.

@YunjieLi
Copy link
Contributor Author

YunjieLi commented Aug 22, 2016

Thanks for the feedback! @samanpwbb
I'm not so sure what do you mean by pixel aligned? I have the artboard setup like this. Does the rooftop triangle look not aligned?
image

@samanpwbb
Copy link
Contributor

Make sure pixel snapping is turned on: vertex positions should be at integer values whenever possible, to ensure the crispest rendering possible:
screen shot 2016-08-22 at 7 31 50 pm

@YunjieLi YunjieLi changed the title add home-15 and home-11 update readme, add home and buddhism Aug 29, 2016
@YunjieLi
Copy link
Contributor Author

YunjieLi commented Sep 2, 2016

If we'll have to bend the guidelines anyway, can we do this @natslaughter

image
buddhism-11

image

@YunjieLi YunjieLi changed the title update readme, add home and buddhism update readme and add home Sep 2, 2016
@aparlato
Copy link
Contributor

cc @natslaughter @samanpwbb

@natslaughter
Copy link
Contributor

@aparlato
Is there any way the home icons could avoid having geometry in the 'trim area?' The 11-pixel icon is pushing to the edges, which might cause some tight, odd conditions when a background or frame is applied to the icon.

@natslaughter natslaughter merged commit 4e237ef into master Jan 2, 2017
@natslaughter natslaughter deleted the new-icon-home branch January 2, 2017 19:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants