Skip to content
This repository has been archived by the owner on Oct 7, 2024. It is now read-only.

Bumped demo and wearable demo up to beta.2 #332

Merged
merged 3 commits into from
May 22, 2017

Conversation

langsmith
Copy link
Contributor

Updated gradle dependency lines

@langsmith langsmith requested a review from cammace May 12, 2017 16:51
@langsmith
Copy link
Contributor Author

langsmith commented May 12, 2017

Note: Don't merge until beta.2 is actually available for download, Maven, etc. This is why tests are failing

@langsmith
Copy link
Contributor Author

langsmith commented May 13, 2017

Tests are failing because of LOST in the Android Wearable app
screen shot 2017-05-12 at 4 56 46 pm

Related to mapbox/mapbox-java#401?
Related to mapbox/mapbox-gl-native#8872?

I'm not sure what to manipulate. Little guidance @tobrun or @zugaldia ?

@cammace
Copy link
Contributor

cammace commented May 13, 2017

This should do the job:

// Mapbox Maps SDK
    compile ('com.mapbox.mapboxsdk:mapbox-android-sdk:5.1.0-beta.2@aar') {
        transitive = true
        exclude module: 'lost'
        exclude module: 'mapbox-java-geojson'
        exclude module: 'mapbox-android-telemetry'
    }

@zugaldia
Copy link
Member

Why are those exclusions needed on the wearable module, but not in the mobile app?

@langsmith
Copy link
Contributor Author

More LOST issues preventing the test build from passing. Thoughts? Remedies?

screen shot 2017-05-15 at 10 29 28 am

@zugaldia
Copy link
Member

@langsmith Looks like you're hitting mapbox/mapbox-gl-native#8999.

@langsmith
Copy link
Contributor Author

Thanks @zugaldia

@langsmith langsmith requested a review from zugaldia May 17, 2017 16:40
Copy link
Member

@zugaldia zugaldia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My bad, I only checked the code and I didn't notice CI was complaining. Let's hold on merging for now.

@langsmith
Copy link
Contributor Author

@zugaldia , with the LOST fix, this PR's tests now pass. Approve so that I can merge?

@langsmith langsmith merged commit 8a1d72b into master May 22, 2017
@langsmith langsmith deleted the ls-bumping-up-to-5.1.0-beta.2 branch May 22, 2017 16:03
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants