Support multiple road classes in RouteOptions.roadClassesToAvoid and RouteOptions.roadClassesToAllow properties
#664
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
azarovalex
force-pushed
the
azarovalex/multiple-avoid-classes
branch
from
fc62551
to
8da8838
Compare
No, these options are still used by |
1ec5
reviewed
Mar 16, 2022
1ec5
reviewed
Mar 16, 2022
bamx23
approved these changes
Mar 17, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Directions server-side API now allows passing multiple road classes in these fields, so the corresponding SDK code is updated.
Looks like
RoadClasses.tunnelandRoadClasses.restrictedare not supported by Directions API inRouteOptions.roadClassesToAvoidanymore, so I updated documentation for these properties.Error when trying to avoid tunnels:
@1ec5 Looks like
RoadClasses.tunnelandRoadClasses.restrictedwere only used inRouteOptions.roadClassesToAvoid, now that Directions API doesn't support them, should we mark these properties as deprecated?