Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix flaky LocationCollectionClientInstrumentedTest #371

Closed
wants to merge 3 commits into from
Closed

Fix flaky LocationCollectionClientInstrumentedTest #371

wants to merge 3 commits into from

Conversation

andrlee
Copy link
Contributor

@andrlee andrlee commented Mar 21, 2019

Some test cases in LocationCollectionClientInstrumentedTest is unstable, use CountDownLatch to instead of sleep.
In unInstall method of LocationCollectionClientInstrumentedTest, we don't unregister listener, so it will not release current object. Call unregisterOnSharedPreferenceChangeListener to fix it.

@andrlee andrlee closed this Mar 21, 2019
@andrlee andrlee deleted the kl-fix-test branch March 21, 2019 23:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@andrlee