Add skuId to the turnstile events #380
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andrlee
force-pushed
the
al-sku-id-turnstile
branch
from
09575bf
to
6f5dfca
Compare
|
Once this PR lands, and a release is out, this is the Maps SDK PR where we plan on integrating this new setter: mapbox/mapbox-gl-native#14404. |
Codecov Report
@@ Coverage Diff @@
## master #380 +/- ##
============================================
+ Coverage 61.71% 61.88% +0.16%
- Complexity 511 516 +5
============================================
Files 98 98
Lines 2975 2967 -8
Branches 207 208 +1
============================================
Hits 1836 1836
+ Misses 1039 1030 -9
- Partials 100 101 +1 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add
SKUfor to the turnstile event to prevent double billing. Also this change exposes a public setterAppUserTurnstile#setSkuId(String), which should be used by our maps sdk to set a default value of00as per spec in order to address potential double billing./cc @tobrun @zugaldia and @Guardiola31337 just in case it has impact on navigation sdk.