Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: export constants and lib through MapboxDraw #1100

Merged
merged 1 commit into from
Jan 25, 2023

Conversation

thaddmt
Copy link
Contributor

@thaddmt thaddmt commented Mar 16, 2022

Overview

@TreTuna
Copy link

TreTuna commented Apr 25, 2022

This is blocking us from updating to the latest version of mapbox-gl-draw and would be great to get feedback from the Mapbox team if this is something that can move forward. We import these utilities specifically in our libraries in order to draw circular geofences efficiently.

@mojodna
Copy link

mojodna commented Apr 25, 2022

@mourner are you able to look at this (or point to another maintainer, assuming that this is still maintained)?

@reesscot
Copy link

Any update on getting this PR reviewed by the maintainers?

Copy link
Contributor

@stepankuzmin stepankuzmin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey everyone! I'm sorry for not getting back to you sooner. This change looks good to me 👍

@stepankuzmin stepankuzmin merged commit f1c3d59 into mapbox:main Jan 25, 2023
@awulkan
Copy link
Contributor

awulkan commented Feb 1, 2023

Awesome, is there any reason why the "mouseEventPoint" function was not exported from the lib? I'm using it in a custom mode.

https://github.com/mapbox/mapbox-gl-draw/blob/main/src/lib/mouse_event_point.js

@random-play
Copy link

Hey everyone! I'm sorry for not getting back to you sooner. This change looks good to me 👍

please sync update the @types/mapbox__mapbox-gl-draw packages (npmjs.com),otherwise to use MapboxDraw.lib will
report errors.

danielsippel added a commit to danielsippel/mapbox-gl-draw that referenced this pull request Apr 17, 2024
danielsippel added a commit to danielsippel/mapbox-gl-draw that referenced this pull request Apr 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants