Use numeric sort comparator for sorting symbol query results.

Matches topDownComparator of FeatureIndex. Previous behavior was string sorting, which could provide unexpected results with multi-digit feature indices. Update query tests to match new order.
mapbox · May 18, 2018 · 021c582 · 021c582
1 parent 63efc49
commit 021c582
Show file tree

Hide file tree

Showing 5 changed files with 591 additions and 591 deletions.
diff --git a/src/symbol/collision_index.js b/src/symbol/collision_index.js
@@ -295,7 +295,7 @@ class CollisionIndex {
             result[featureKey.bucketInstanceId].push(featureKey.featureIndex);
         }
         for (const bucket in result) {
-            result[bucket].sort();
+            result[bucket].sort((a, b) => b - a); // Match topDownFeatureComparator from FeatureIndex
         }
 
         return result;

diff --git a/test/integration/query-tests/symbol-features-in/pitched-screen/expected.json b/test/integration/query-tests/symbol-features-in/pitched-screen/expected.json
@@ -25,7 +25,7 @@
     "geometry": {
       "type": "Point",
       "coordinates": [
-        2.9999542236328125,
+        4.000053405761719,
         4.000061604283047
       ]
     },
@@ -47,7 +47,7 @@
     "geometry": {
       "type": "Point",
       "coordinates": [
-        4.000053405761719,
+        2.9999542236328125,
         4.000061604283047
       ]
     },