fix #8481, unbounded memory growth in IE (#8490)

Cancellable requests to workers should never call back after they have been cancelled.
mapbox · Jul 18, 2019 · 9e17462 · 9e17462
1 parent 2dbd0dd
commit 9e17462
Showing 1 changed file with 10 additions and 6 deletions.
diff --git a/src/util/actor.js b/src/util/actor.js
@@ -56,12 +56,16 @@ class Actor {
         }, buffers);
         if (callback) {
             return {
-                cancel: () => this.target.postMessage({
-                    targetMapId,
-                    sourceMapId: this.mapId,
-                    type: '<cancel>',
-                    id: String(id)
-                })
+                cancel: () => {
+                    // Set the callback to null so that it never fires after the request is aborted.
+                    this.callbacks[id] = null;
+                    this.target.postMessage({
+                        targetMapId,
+                        sourceMapId: this.mapId,
+                        type: '<cancel>',
+                        id: String(id)
+                    });
+                }
             };
         }
     }