Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename layer option to layers for featuresIn/At requests #2230

Closed
tristen opened this issue Mar 8, 2016 · 5 comments
Closed

Rename layer option to layers for featuresIn/At requests #2230

tristen opened this issue Mar 8, 2016 · 5 comments
Assignees

Comments

@tristen
Copy link
Member

tristen commented Mar 8, 2016

I've seen this come up a couple times where someone has typed layers instead of layer in the property options for featuresAt or featuresIn requests. If the typo is not caught the effect is elusive (appears to sort of work as the layer you want is captured in the request but buggy as it captures others)

Propose:

  • layer continues to accept a single string value or an array of strings
  • layers accepts an array of strings
@lucaswoj
Copy link
Contributor

lucaswoj commented Mar 8, 2016

someone

👍 I've done this many times.

@tmcw
Copy link
Contributor

tmcw commented Mar 8, 2016

👎 rename to layers, require an array of strings as an argument. One true way.

@tristen tristen changed the title Support layers option for featuresIn/At requests Rename layer option to layers for featuresIn/At requests Mar 14, 2016
@averas
Copy link
Contributor

averas commented Mar 14, 2016

I agree with @tmcw.

@peterqliu
Copy link
Contributor

Agree with one true way, though should we continue to support the singular form, to avoid a breaking change?

@jfirebaugh
Copy link
Contributor

Let's support an array-valued layers property only, as part of #2052 / #2224, which are already breaking changes.

cc @ansis

@ansis ansis self-assigned this Mar 14, 2016
ansis added a commit that referenced this issue Mar 15, 2016
and accept only an array of strings.

fix #2230
ansis added a commit that referenced this issue Mar 15, 2016
and accept only an array of strings.

fix #2230
ansis added a commit that referenced this issue Mar 16, 2016
and accept only an array of strings.

fix #2230
ansis added a commit that referenced this issue Mar 16, 2016
and accept only an array of strings.

fix #2230
ansis added a commit that referenced this issue Mar 17, 2016
and accept only an array of strings.

fix #2230
ansis added a commit that referenced this issue Mar 21, 2016
and accept only an array of strings.

fix #2230
@ansis ansis closed this as completed in dfb96c8 Mar 24, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

7 participants