Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create a UI debug control #2290

Closed
lucaswoj opened this issue Mar 18, 2016 · 4 comments
Closed

Create a UI debug control #2290

lucaswoj opened this issue Mar 18, 2016 · 4 comments

Comments

@lucaswoj
Copy link
Contributor

We should consider adding a mapboxgl.DebugControl class which adds UI controls for toggling "tile debug" and "collision debug" modes (and future debug capabilities).

ref #2281 (comment)
ref #2284 (comment)

cc @bhousel @mourner @jfirebaugh @ansis

@lucaswoj
Copy link
Contributor Author

I feel mildly 👎 towards this proposal on the grounds that

  • we should add as little debugging code to the distributed mapbox-gl.js as possible
  • toggling tileDebug and collisionDebug is easy from the console
  • users who are likely to find tileDebug and collisionDebug useful are likely to be designers within the Studio interface or developers comfortable using the console

@mourner
Copy link
Member

mourner commented Mar 18, 2016

I don't see the need for a dedicated control — a debug page and ability to use console are enough.

@bhousel
Copy link
Contributor

bhousel commented Mar 18, 2016

Then why open an issue for it?? Just to tell me my idea sucks?

In the amount of time we have discussed it, I probably could have built the damn thing. I did most of a geolocation control yesterday in like 2 hours.

This is nuts.

@bhousel bhousel closed this as completed Mar 18, 2016
@mourner
Copy link
Member

mourner commented Mar 18, 2016

Then why open an issue for it?? Just to tell me my idea sucks?

Not at all! I'm sorry it looked that way. 🐼 We open an issue for any improvement idea to have our decisions documented and easily searchable. Sometimes this can be an overkill, but we all make mistakes sometimes. ❤️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants