Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move buffer stats to a separate debug page #2281

Closed
lucaswoj opened this issue Mar 17, 2016 · 6 comments · Fixed by #3596
Closed

Move buffer stats to a separate debug page #2281

lucaswoj opened this issue Mar 17, 2016 · 6 comments · Fixed by #3596

Comments

@lucaswoj
Copy link
Contributor

screen shot 2016-03-17 at 11 44 28 am

I want to keep the index.html debug page simple. "debug" and "collision debug" modes can stay.

@mourner
Copy link
Member

mourner commented Mar 17, 2016

That would be great! I'd also remove the random points geojson and leave only the route one.

@bhousel
Copy link
Contributor

bhousel commented Mar 17, 2016

Worth mentioning - I was thinking of adding an "events debug" too.

I don't mind having buffer stats there. Honestly I'd prefer to have all the debug things consolidated in one control rather than spread across different pages - but no strong opinion on this.

@lucaswoj
Copy link
Contributor Author

I often use debug/index.html to build ephemeral testing "rigs". For that use-case, having a simple page possible is ideal (i.e. new mapboxgl.Map(...) and nothing else).

Some testing rigs are worth checking in and reusing, like "buffer stats." Keeping those rigs on separate pages

  • frees us from having to build and maintain any enable / disable UI
  • frees testing rigs from having to "play nicely" with other rigs on the same page, allowing more "radical" setups (i.e. requireing and manipulating internal modules directly or displaying custom UI elements)
  • scales infinitely with the number of testing rigs we create

@lucaswoj lucaswoj mentioned this issue Mar 18, 2016
2 tasks
@mourner
Copy link
Member

mourner commented Mar 18, 2016

I agree with @lucaswoj — when I'm debugging a particular feature, I'll usually start by removing everything but the barebones code from site.js and start from there. It's cumbersome to do every time, so having a nice default simple debug page would be a time saver.

@bhousel
Copy link
Contributor

bhousel commented Mar 18, 2016

Wouldn't it be better if the debugging things were contained in a Control like:

map.addControl(new mapboxgl.Debug({position: 'top-left'}));

I agree index.html and site.js ideally shouldn't have this extra code.

@lucaswoj lucaswoj modified the milestone: v1.0.0 Jun 29, 2016
@lucaswoj lucaswoj added the v1 label Jul 28, 2016
@lucaswoj lucaswoj removed this from the v1.0.0 milestone Jul 28, 2016
@mourner
Copy link
Member

mourner commented Nov 11, 2016

-> #3596

@mourner mourner closed this as completed Nov 11, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants