-
Notifications
You must be signed in to change notification settings - Fork 2.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
map containers larger than 4096px are scaled #2673
Comments
I don't think we can do anything about this in GL JS code if it's a browser limitation. Apparently max renderbuffer size translates to half of that in pixels. |
@mourner Thanks for the explanation, I didn't realise that gl.MAX_RENDERBUFFER_SIZE translates to half of it in pixels, so I thought it was an issue in GL JS. I'm interested why it translates to half. But given that, I'll have to go ahead with a workaround for my specific use case of generating high-res images for print by pasting together 4096x4096 tiles. |
That's just a guess, — I don't know for sure. Let's reopen if this turns out to be something that can be fixed on our side. |
Let's reopen if this turns out to be something that can be fixed on our side. |
From #3915 (comment)
@1ec5 I can confirm this. For me on Chrome 0.19.1 still suffers from this issue, but it appears fixed in 0.28.0. Which is awesome! My gl.MAX_RENDERBUFFER_SIZE is still 8192 which is the size of the map I used to test. |
mapbox-gl-js version: 0.19.1
Steps to Trigger Behavior
demo: http://jsbin.com/hadiravumo/1/edit?html,output
Expected Behavior
I expect the map to be crisp and not over scaled. This is what the 4096x4096px map looks like, nice and crisp, and what I expect the 8192x8192px map to look like (just a larger area as the zoom is the same in both cases).
Actual Behavior
It's blurry because it is rendered at 4096x4096px map but scaled by 2x. The 8192x8192px map looks like this:
returns 8192 which indicates that WebGL canvases that big should work?
window.devicePixelRatio
is 1.The text was updated successfully, but these errors were encountered: