-
Notifications
You must be signed in to change notification settings - Fork 2.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
style-property-aware hit testing #316
Comments
How would we define the property to depend on API-wise? |
not sure. Maybe have it be the default unless a |
I mean, how would llmr know that we need to check e.g. |
We would process the style so that we have a radius for each bucket and send those over to the worker. When doing the rtree query it would just use the max radius. Each feature from the tree should have a |
I think there are still times when you want to designate a bigger 'hit area' for a feature. If you have a 2px radius dot, for example, you could set the radius higher to be more clickable. Maybe we could set the default for each bucket to be true to the current map style, but allow for radius override? |
Do you mean in terms of map interactivity design? Or something else? |
Map interactivity. Right now |
This may be unrelated, but another interesting option here is to support voronoi-style interaction to get the closest point. D3 example: http://bl.ocks.org/mbostock/7608400 |
Neat @edenh. That's particularly interesting for touch/native given the ~44px wiggle room a "point" typically has there. |
map.featuresAt now includes features whose rendered representation matches the query, not features whose geometry matches the query. A query with `radius: 0` will now match lines and circles if the point is within the rendered line. also fix #2053 It now checks intersection based on the render type not the geometry type. A polygon that is rendered as a line will only match if the query matches the line. It will not include it if the query only matches in the internal part of the polygon. implemented: circle-radius circle-translate fill-translate line-width line-offset line-translate not implemented yet (hard with the current symbol index): text-translate icon-translate
map.featuresAt now includes features whose rendered representation matches the query, not features whose geometry matches the query. A query with `radius: 0` will now match lines and circles if the point is within the rendered line. also fix #2053 It now checks intersection based on the render type not the geometry type. A polygon that is rendered as a line will only match if the query matches the line. It will not include it if the query only matches in the internal part of the polygon. implemented: circle-radius circle-translate fill-translate line-width line-offset line-translate not implemented yet (hard with the current symbol index): text-translate icon-translate
map.featuresAt now includes features whose rendered representation matches the query, not features whose geometry matches the query. A query with `radius: 0` will now match lines and circles if the point is within the rendered line. also fix #2053 It now checks intersection based on the render type not the geometry type. A polygon that is rendered as a line will only match if the query matches the line. It will not include it if the query only matches in the internal part of the polygon. implemented: circle-radius circle-translate fill-translate line-width line-offset line-translate not implemented yet (hard with the current symbol index): text-translate icon-translate
map.featuresAt now includes features whose rendered representation matches the query, not features whose geometry matches the query. A query with `radius: 0` will now match lines and circles if the point is within the rendered line. also fix #2053 It now checks intersection based on the render type not the geometry type. A polygon that is rendered as a line will only match if the query matches the line. It will not include it if the query only matches in the internal part of the polygon. implemented: circle-radius circle-translate fill-translate line-width line-offset line-translate not implemented yet (hard with the current symbol index): text-translate icon-translate
map.featuresAt now includes features whose rendered representation matches the query, not features whose geometry matches the query. A query with `radius: 0` will now match lines and circles if the point is within the rendered line. also fix #2053 It now checks intersection based on the render type not the geometry type. A polygon that is rendered as a line will only match if the query matches the line. It will not include it if the query only matches in the internal part of the polygon. implemented: circle-radius circle-translate fill-translate line-width line-offset line-translate not implemented yet (hard with the current symbol index): text-translate icon-translate
map.featuresAt now includes features whose rendered representation matches the query, not features whose geometry matches the query. A query with `radius: 0` will now match lines and circles if the point is within the rendered line. also fix #2053 It now checks intersection based on the render type not the geometry type. A polygon that is rendered as a line will only match if the query matches the line. It will not include it if the query only matches in the internal part of the polygon. implemented: circle-radius circle-translate fill-translate line-width line-offset line-translate not implemented yet (hard with the current symbol index): text-translate icon-translate
map.featuresAt now includes features whose rendered representation matches the query, not features whose geometry matches the query. A query with `radius: 0` will now match lines and circles if the point is within the rendered line. also fix #2053 It now checks intersection based on the render type not the geometry type. A polygon that is rendered as a line will only match if the query matches the line. It will not include it if the query only matches in the internal part of the polygon. implemented: circle-radius circle-translate fill-translate line-width line-offset line-translate not implemented yet (hard with the current symbol index): text-translate icon-translate
map.featuresAt now includes features whose rendered representation matches the query, not features whose geometry matches the query. A query with `radius: 0` will now match lines and circles if the point is within the rendered line. also fix #2053 It now checks intersection based on the render type not the geometry type. A polygon that is rendered as a line will only match if the query matches the line. It will not include it if the query only matches in the internal part of the polygon. implemented: circle-radius circle-translate fill-translate line-width line-offset line-translate not implemented yet (hard with the current symbol index): text-translate icon-translate
map.featuresAt now includes features whose rendered representation matches the query, not features whose geometry matches the query. A query with `radius: 0` will now match lines and circles if the point is within the rendered line. also fix #2053 It now checks intersection based on the render type not the geometry type. A polygon that is rendered as a line will only match if the query matches the line. It will not include it if the query only matches in the internal part of the polygon. implemented: circle-radius circle-translate fill-translate line-width line-offset line-translate not implemented yet (hard with the current symbol index): text-translate icon-translate
map.featuresAt now includes features whose rendered representation matches the query, not features whose geometry matches the query. A query with `radius: 0` will now match lines and circles if the point is within the rendered line. also fix #2053 It now checks intersection based on the render type not the geometry type. A polygon that is rendered as a line will only match if the query matches the line. It will not include it if the query only matches in the internal part of the polygon. implemented: circle-radius circle-translate fill-translate line-width line-offset line-translate not implemented yet (hard with the current symbol index): text-translate icon-translate
map.featuresAt now includes features whose rendered representation matches the query, not features whose geometry matches the query. A query with `radius: 0` will now match lines and circles if the point is within the rendered line. also fix #2053 It now checks intersection based on the render type not the geometry type. A polygon that is rendered as a line will only match if the query matches the line. It will not include it if the query only matches in the internal part of the polygon. implemented: circle-radius circle-translate fill-translate line-width line-offset line-translate not implemented yet (hard with the current symbol index): text-translate icon-translate
map.featuresAt now includes features whose rendered representation matches the query, not features whose geometry matches the query. A query with `radius: 0` will now match lines and circles if the point is within the rendered line. also fix #2053 It now checks intersection based on the render type not the geometry type. A polygon that is rendered as a line will only match if the query matches the line. It will not include it if the query only matches in the internal part of the polygon. implemented: circle-radius circle-translate fill-translate line-width line-offset line-translate not implemented yet (hard with the current symbol index): text-translate icon-translate
map.featuresAt current takes a constant radius as one of the parameters. For interaction, it would be useful to be able to have this radius depend on the map style.
For example, if
road_regular
width is 10 the radius would be 5.The text was updated successfully, but these errors were encountered: