Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Overdrawn symbols at tile corner #4617

Closed
jfirebaugh opened this issue Apr 19, 2017 · 4 comments
Closed

Overdrawn symbols at tile corner #4617

jfirebaugh opened this issue Apr 19, 2017 · 4 comments
Assignees
Labels

Comments

@jfirebaugh
Copy link
Contributor

jfirebaugh commented Apr 19, 2017

If you have a symbol layer with text for a feature at null island, at any zoom level other than 0, it'll be overdrawn. Presumably what's happening is that the feature appears within all of the four tiles which have a corner at null island, and is getting drawn by all of them.

Test case:

{
  "version": 8,
  "metadata": {
    "test": {
      "height": 64,
      "width": 64
    }
  },
  "zoom": 1,
  "sources": {
    "point": {
      "type": "geojson",
      "data": {
        "type": "Point",
        "coordinates": [ 0, 0 ]
      }
    }
  },
  "glyphs": "local://glyphs/{fontstack}/{range}.pbf",
  "layers": [
    {
      "id": "text",
      "type": "symbol",
      "source": "point",
      "layout": {
        "text-field": "xxx",
        "text-font": [
          "Open Sans Semibold",
          "Arial Unicode MS Bold"
        ]
      }
    }
  ]
}

Expected result:

image

Actual result:

image

@jfirebaugh
Copy link
Contributor Author

See #4729 for another demo of this issue.

@jfirebaugh
Copy link
Contributor Author

@ChrisLoer This should be fixed by viewport collision detection, right?

@ChrisLoer
Copy link
Contributor

@jfirebaugh Yup, I'll turn this into a regression test case and close it.

@ChrisLoer
Copy link
Contributor

Fixed in #5150, test in #5515.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants