Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CSS - control group box shadow still visible when empty #7303

Closed
Duder-onomy opened this issue Sep 20, 2018 · 0 comments
Closed

CSS - control group box shadow still visible when empty #7303

Duder-onomy opened this issue Sep 20, 2018 · 0 comments

Comments

@Duder-onomy
Copy link

Hi!

When a maps control group is empty, you can still see the control groups box shadow:
image

mapbox-gl-js version: #master

browser: All

Steps to Trigger Behavior

  1. Attempt to render the 'geolocation' control
  2. Block geolocation access in your browser.
    In Chrome:
    Go to settings -> advanced -> location Add the current URL to your block list.

Expected Behavior

The selector .mapboxgl-ctrl-group should not render its box-shadow when it has no children.

Actual Behavior

It renders its box shadow always.


I think a simple fix for this would be to use the :not(:empty) selector when applying the box shadow to the control-group.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant