Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

double tap to zoom in does not work on iOS 13 #9756

Closed
ansis opened this issue Jun 3, 2020 · 0 comments · Fixed by #9757
Closed

double tap to zoom in does not work on iOS 13 #9756

ansis opened this issue Jun 3, 2020 · 0 comments · Fixed by #9757
Labels
bug 🐞

Comments

@ansis
Copy link
Contributor

ansis commented Jun 3, 2020

mapbox-gl-js version: 1.10.1

browser: iOS Safari 13

Steps to Trigger Behavior

  1. open any map in iOS safari 13
  2. double tap

Link to Demonstration

https://docs.mapbox.com/mapbox-gl-js/example/simple-map/

Expected Behavior

Map zooms in.

Actual Behavior

Map does not zoom in.
@ansis ansis added the bug 🐞 label Jun 3, 2020
ansis added a commit that referenced this issue Jun 3, 2020
@ansis
fix double tap zoom on iOS 13
0319e42 
fix #9756

iOS 13 does not fire the second touchstart/end events in a double tap if
the touchstart listener is non-passive. This fix makes it passive.

Calling preventDefault() allows the second event to be fired but
suppresses other events like `click`.

`touchmove` needs to remain non-passive so that it can be used to
prevent touches from scrolling or scaling the page on some versions of
iOS Safari.
@ansis ansis mentioned this issue Jun 3, 2020
Merged
5 tasks
ansis added a commit that referenced this issue Jun 8, 2020
@ansis
fix double tap zoom on iOS 13 (#9757)
25cc7a9 
fix #9756

iOS 13 does not fire the second touchstart/end events in a double tap if
the touchstart listener is non-passive. This fix makes it passive.

Calling preventDefault() allows the second event to be fired but
suppresses other events like `click`.

`touchmove` needs to remain non-passive so that it can be used to
prevent touches from scrolling or scaling the page on some versions of
iOS Safari.
ansis added a commit that referenced this issue Jun 8, 2020
@ansis
fix double tap zoom on iOS 13 (#9757)
5bc2484 
fix #9756

iOS 13 does not fire the second touchstart/end events in a double tap if
the touchstart listener is non-passive. This fix makes it passive.

Calling preventDefault() allows the second event to be fired but
suppresses other events like `click`.

`touchmove` needs to remain non-passive so that it can be used to
prevent touches from scrolling or scaling the page on some versions of
iOS Safari.
ansis added a commit that referenced this issue Jun 8, 2020
@ansis
fix double tap zoom on iOS 13 (#9757)
97b7372 
fix #9756

iOS 13 does not fire the second touchstart/end events in a double tap if
the touchstart listener is non-passive. This fix makes it passive.

Calling preventDefault() allows the second event to be fired but
suppresses other events like `click`.

`touchmove` needs to remain non-passive so that it can be used to
prevent touches from scrolling or scaling the page on some versions of
iOS Safari.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug 🐞
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix double tap zoom on iOS 13 mapbox/mapbox-gl-js
1 participant
@ansis