Add hasControl method #10035
Merged
Add hasControl method #10035
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ryanhamley
suggested changes
Oct 20, 2020
src/ui/map.js
Outdated
Comment on lines
572
to
575
| if (!control || typeof control !== 'object') { | ||
| return this.fire(new ErrorEvent(new Error( | ||
| 'Invalid argument to map.hasControl(). Argument must be a control.'))); | ||
| } |
There was a problem hiding this comment.
I'm not sure if this is really necessary. An undefined value or something that isn't an object would return false which I think is sufficient
ryanhamley
approved these changes
Oct 21, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Launch Checklist
Adds a
hasControlmethod tosrc/ui/map.jsso clients can detect whether a control already exists before callingaddControlorremoveControl.include before/after visuals or gifs if this PR includes visual changespost benchmark scorestagged@mapbox/map-design-team@mapbox/static-apisif this PR includes style spec API or visual changestagged@mapbox/gl-nativeif this PR includes shader changes or needs a native portmapbox-gl-jschangelog:<changelog>Adds ahasControlmethod to map</changelog>