Clear out the content container rather than deleting it #10036
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Launch Checklist
This PR changes behavior in popup.js. Currently, when
setDOMContent
is called, it destroys the content container, creates a new one, and populates. This is undesirable under situations where you don't want to introduce a CSS file as a dependency to a plugin and wish to modify the content container using JavaScript.Right now I'm calling this every time I want to add new data (which is happening on mouseover when
queryRenderedFeatures
returns a response):I would prefer to modify the DOM once and not have this be repeatedly called.
I'm a little nervous this constitutes a breaking change even though it's minor. Curious what y'all thoughts are.
include before/after visuals or gifs if this PR includes visual changestagged@mapbox/map-design-team
@mapbox/static-apis
if this PR includes style spec API or visual changestagged@mapbox/gl-native
if this PR includes shader changes or needs a native portmapbox-gl-js
changelog:<changelog>Clear out the popup content container instead of deleting it</changelog>