Fix a bug in which map.setStyle() could not be used to enable terrain. #10177
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
arindam1993
commented
Dec 10, 2020
| @@ -1412,7 +1412,6 @@ class Map extends Camera { | |||
| try { | |||
| if (this.style.setState(style)) { | |||
| this._update(true); | |||
| this._updateTerrain(); | |||
There was a problem hiding this comment.
Removing this is fine because _update calls setTerrain since it performs a style diff internally.
arindam1993
changed the title
setStyle style diffing
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We weren't handling the usage of the
setTerraincommand in style diffing correctly.Theres a cyclic dependency between terrain and source. This is analogous to layers.This change ensures that we remove the terrain if the source is being removed, and then in a 2nd pass add it back in with a modified source if necessary.
Launch Checklist
mapbox-gl-jschangelog:<changelog>Fix a bug in which map.setStyle() could not be used to enable terrain.</changelog>