Fix fullscreen fill-extrusion querying at low pitch #10315
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The way query geometry was being constructed for fill-extrusions was incorrect for bounds based queries in which the point underneath the camera would fall within the query volume.
This PR fixes it by considering all 4 possible cases
I've added some ASCII art code comments to make it clearer.
Launch Checklist
mapbox-gl-js
changelog:<changelog>Fill fullscreen fill-extrusion querying at low pitch.</changelog>