Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add getTerrain method #10413

Merged
merged 2 commits into from
Mar 8, 2021
Merged

Add getTerrain method #10413

merged 2 commits into from
Mar 8, 2021

Conversation

ryanhamley
Copy link
Contributor

Launch Checklist

  • briefly describe the changes in this PR
  • write tests for all new functionality
  • document any changes to public APIs
  • manually test the debug page
  • apply changelog label ('bug', 'feature', 'docs', etc) or use the label 'skip changelog'
  • add an entry inside this element for inclusion in the mapbox-gl-js changelog: <changelog>Add map.getTerrain() method</changelog>

@ryanhamley ryanhamley self-assigned this Feb 25, 2021
@karimnaaji karimnaaji added this to the v2.2 milestone Mar 1, 2021
karimnaaji
karimnaaji reviewed Mar 8, 2021
View reviewed changes
src/style/style.js Outdated Show resolved Hide resolved
karimnaaji
karimnaaji reviewed Mar 8, 2021
View reviewed changes
src/style/style.js Outdated Show resolved Hide resolved
karimnaaji
karimnaaji reviewed Mar 8, 2021
View reviewed changes
Copy link
Contributor

@karimnaaji karimnaaji left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left a few suggestions/update to docs based on the first comment.

src/ui/map.js Outdated Show resolved Hide resolved
src/ui/map.js Outdated Show resolved Hide resolved
src/ui/map.js Outdated Show resolved Hide resolved
karimnaaji
karimnaaji approved these changes Mar 8, 2021
View reviewed changes
Copy link
Contributor

@karimnaaji karimnaaji left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@karimnaaji karimnaaji merged commit 719301f into main Mar 8, 2021
@karimnaaji karimnaaji deleted the getterrain branch March 8, 2021 23:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@karimnaaji karimnaaji karimnaaji approved these changes

@ansis ansis Awaiting requested review from ansis

Assignees

@ryanhamley ryanhamley

Labels
feature 🍏
Projects
None yet
Milestone
v2.2
Development

Successfully merging this pull request may close these issues.

add map.getTerrain()
2 participants
@ryanhamley @karimnaaji