Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Data-driven line-dasharray and line-cap #10591

Merged
merged 29 commits into from
May 6, 2021
Merged

Data-driven line-dasharray and line-cap #10591

merged 29 commits into from
May 6, 2021

Commits on Apr 7, 2021

  1. WIP data-driven line-dasharray / line-cap (not working yet)

    @mourner
    mourner committed Apr 7, 2021
    Configuration menu
    Copy the full SHA
    92d3059 View commit details
    Browse the repository at this point in the history

Commits on Apr 9, 2021

  1. WIP pass the per-tile line atlas through

    @mourner
    mourner committed Apr 9, 2021
    Configuration menu
    Copy the full SHA
    c2855d5 View commit details
    Browse the repository at this point in the history

Commits on Apr 12, 2021

  1. WIP switch to integer coords for line atlas

    @mourner
    mourner committed Apr 12, 2021
    Configuration menu
    Copy the full SHA
    6d3f045 View commit details
    Browse the repository at this point in the history

  2. add a dds dasharray debug page (temp)

    @mourner
    mourner committed Apr 12, 2021
    Configuration menu
    Copy the full SHA
    dca713a View commit details
    Browse the repository at this point in the history

  3. fix debug page

    @mourner
    mourner committed Apr 12, 2021
    Configuration menu
    Copy the full SHA
    48a6303 View commit details
    Browse the repository at this point in the history

Commits on Apr 13, 2021

  1. use different attribute names for dashes to avoid collision 

    The attribute names used for dashes were the same as those used for
patterns. This was leading to incorrectly generated shaders.

Since there was no pattern set for the dash layer it was setting the
defines that generate the shader without those attributes.

The line atlas texture is now bound with gl.REPEAT to render more than
one dash.
    @ansis
    ansis committed Apr 13, 2021
    Configuration menu
    Copy the full SHA
    2203861 View commit details
    Browse the repository at this point in the history

Commits on Apr 14, 2021

  1. fix DDS dasharray rendering

    @mourner
    mourner committed Apr 14, 2021
    Configuration menu
    Copy the full SHA
    ff328d8 View commit details
    Browse the repository at this point in the history

Commits on Apr 16, 2021

  1. refactor to support constant patterns

    @mourner
    mourner committed Apr 16, 2021
    Configuration menu
    Copy the full SHA
    304c290 View commit details
    Browse the repository at this point in the history

  2. fix constant dasharrays

    @mourner
    mourner committed Apr 16, 2021
    Configuration menu
    Copy the full SHA
    2383ac5 View commit details
    Browse the repository at this point in the history

Commits on Apr 17, 2021

  1. dasharray fixes

    @mourner
    mourner committed Apr 17, 2021
    Configuration menu
    Copy the full SHA
    3171140 View commit details
    Browse the repository at this point in the history

  2. more dasharray fixes

    @mourner
    mourner committed Apr 17, 2021
    Configuration menu
    Copy the full SHA
    fb5f552 View commit details
    Browse the repository at this point in the history

Commits on Apr 19, 2021

  1. fix line atlas unit tests

    @mourner
    mourner committed Apr 19, 2021
    Configuration menu
    Copy the full SHA
    54cbbe0 View commit details
    Browse the repository at this point in the history

  2. more unit test fixes

    @mourner
    mourner committed Apr 19, 2021
    Configuration menu
    Copy the full SHA
    c5ed1c8 View commit details
    Browse the repository at this point in the history

  3. fix remaining render test

    @mourner
    mourner committed Apr 19, 2021
    Configuration menu
    Copy the full SHA
    9756f3a View commit details
    Browse the repository at this point in the history

  4. one more unit test fix

    @mourner
    mourner committed Apr 19, 2021
    Configuration menu
    Copy the full SHA
    7057bfb View commit details
    Browse the repository at this point in the history

Commits on Apr 21, 2021

  1. optimize dash buffer layout

    @mourner
    mourner committed Apr 21, 2021
    Configuration menu
    Copy the full SHA
    4d7ddbf View commit details
    Browse the repository at this point in the history

  2. fixup line pattern

    @mourner
    mourner committed Apr 21, 2021
    Configuration menu
    Copy the full SHA
    20632fe View commit details
    Browse the repository at this point in the history

  3. fix constant dash + dds line-cap

    @mourner
    mourner committed Apr 21, 2021
    Configuration menu
    Copy the full SHA
    87d4748 View commit details
    Browse the repository at this point in the history

  4. fixup

    @mourner
    mourner committed Apr 21, 2021
    Configuration menu
    Copy the full SHA
    a228a36 View commit details
    Browse the repository at this point in the history

Commits on Apr 22, 2021

  1. fix dasharray + composite line-cap

    @mourner
    mourner committed Apr 22, 2021
    Configuration menu
    Copy the full SHA
    955a96d View commit details
    Browse the repository at this point in the history

  2. fix dasharray flickering when crossing zoom stops

    @mourner
    mourner committed Apr 22, 2021
    Configuration menu
    Copy the full SHA
    4f10225 View commit details
    Browse the repository at this point in the history

Commits on Apr 23, 2021

  1. dasharray perf optimizations

    @mourner
    mourner committed Apr 23, 2021
    Configuration menu
    Copy the full SHA
    8c5b978 View commit details
    Browse the repository at this point in the history

  2. clean up leftovers

    @mourner
    mourner committed Apr 23, 2021
    Configuration menu
    Copy the full SHA
    03873b2 View commit details
    Browse the repository at this point in the history

Commits on Apr 28, 2021

  1. minor optimization in program_configuration

    @mourner
    mourner committed Apr 28, 2021
    Configuration menu
    Copy the full SHA
    020260e View commit details
    Browse the repository at this point in the history

Commits on Apr 29, 2021

  1. add data-driven dash/cap render tests

    @mourner
    mourner committed Apr 29, 2021
    Configuration menu
    Copy the full SHA
    d94f9cb View commit details
    Browse the repository at this point in the history

Commits on Apr 30, 2021

  1. add a render test for solid line data-driven line-cap

    @mourner
    mourner committed Apr 30, 2021
    Configuration menu
    Copy the full SHA
    bc726e9 View commit details
    Browse the repository at this point in the history

Commits on May 5, 2021

  1. make shaders more consistent for easier porting

    @mourner
    mourner committed May 5, 2021
    Configuration menu
    Copy the full SHA
    bf73eea View commit details
    Browse the repository at this point in the history

  2. rename conflicting shader constant

    @mourner
    mourner committed May 5, 2021
    Configuration menu
    Copy the full SHA
    c79f577 View commit details
    Browse the repository at this point in the history

Commits on May 6, 2021

  1. fix out of atlas space warning in some cases

    @mourner
    mourner committed May 6, 2021
    Configuration menu
    Copy the full SHA
    2a035f3 View commit details
    Browse the repository at this point in the history