Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Data-driven text-line-height #10612

Merged
merged 2 commits into from
May 6, 2021
Merged

Data-driven text-line-height #10612

merged 2 commits into from
May 6, 2021

Conversation

mourner
Copy link
Member

@mourner mourner commented Apr 23, 2021 •
edited
Loading

Implement data-driven expressions support for text-line-height property. It turned out to be basically a one-line change.

Launch Checklist

  • briefly describe the changes in this PR
  • write tests for all new functionality
  • document any changes to public APIs
  • manually test the debug page
  • tagged @mapbox/map-design-team if this PR includes style spec API or visual changes
  • tagged @mapbox/gl-native if this PR includes shader changes or needs a native port
  • apply changelog label ('bug', 'feature', 'docs', etc) or use the label 'skip changelog'
  • add an entry inside this element for inclusion in the mapbox-gl-js changelog: <changelog>Add support for data-driven text-line-height</changelog>

@mourner mourner marked this pull request as ready for review April 29, 2021 16:11
@mourner mourner requested a review from ansis April 29, 2021 16:21
@mourner mourner added this to the v2.3 milestone Apr 30, 2021
@mourner mourner merged commit 6de0217 into main May 6, 2021
@mourner mourner deleted the data-driven-text-line-height branch May 6, 2021 09:02
@asheemmamoowala asheemmamoowala mentioned this pull request May 17, 2021
Open
@enersis-pst
Copy link
Contributor

please add to documentation.

@mourner
Copy link
Member Author

mourner commented May 20, 2021

@enersis-pst the docs will be updated after the final v2.3.0 release (which is currently in beta).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ansis ansis ansis approved these changes

Assignees
No one assigned
Labels
feature 🍏
Projects
None yet
Milestone
v2.3
Development

Successfully merging this pull request may close these issues.
3 participants
@mourner @enersis-pst @ansis