Fix ImageSource breaking in FF/Safari if it's not immediately displayed #10698
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rreusser
approved these changes
May 24, 2021
| @@ -78,7 +79,7 @@ class ImageSource extends Evented implements Source { | |||
| dispatcher: Dispatcher; | |||
| map: Map; | |||
| texture: Texture | null; | |||
| image: HTMLImageElement | ImageBitmap; | |||
| image: ImageData; | |||
There was a problem hiding this comment.
Question: Makes perfect sense. Just out of curiosity, it seems this is not set until loaded. As far as flow goes, is ImageData | null just not worth the trouble in this case?
There was a problem hiding this comment.
I just didn't change the status quo in this particular PR, but we do need to make a sweep to clean this up — sloppy typing like this is everywhere both in this class and all over the codebase, and Flow isn't complaining. :(
SnailBones
pushed a commit
to SnailBones/mapbox-gl-js
that referenced
this pull request
Jul 15, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #10685 by immediately decoding an image of an
ImageSourceon load for use later so that we don't hit a race condition where the memory for it is freed preemptively.Launch Checklist
mapbox-gl-jschangelog:<changelog>Fix ImageSource breaking in FF/Safari if it's not immediately visible.</changelog>