Fix precision issue in gradient skybox shader #10703
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Gradient skybox is suffering from precision issues on some of the ARM Mali gpus resulting in "wobbly"/jittery movement of the gradient effect on both gl-js and gl-native. This is caused by the uniform
u_center_direction
inskybox_gradient.fragment.glsl
shader being defined aslowp
. Increasing the precision tohighp
fixes the issue.Record_2021_0525_1300-00.00.18.531-00.00.36.515.mp4
mapbox-gl-js
changelog:<changelog>Fix gradient skybox rendering issue on some ARM Mali gpus</changelog>