Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix precision issue in gradient skybox shader #10703

Merged
merged 1 commit into from
May 25, 2021

Conversation

mpulkki-mapbox
Copy link
Contributor

Gradient skybox is suffering from precision issues on some of the ARM Mali gpus resulting in "wobbly"/jittery movement of the gradient effect on both gl-js and gl-native. This is caused by the uniform u_center_direction in skybox_gradient.fragment.glsl shader being defined as lowp. Increasing the precision to highp fixes the issue.

Record_2021_0525_1300-00.00.18.531-00.00.36.515.mp4
  • briefly describe the changes in this PR
  • include before/after visuals or gifs if this PR includes visual changes
  • manually test the debug page
  • apply changelog label ('bug', 'feature', 'docs', etc) or use the label 'skip changelog'
  • add an entry inside this element for inclusion in the mapbox-gl-js changelog: <changelog>Fix gradient skybox rendering issue on some ARM Mali gpus</changelog>

@karimnaaji karimnaaji merged commit 73544cc into main May 25, 2021
@karimnaaji karimnaaji deleted the mpulkki-fix-gradient-sky-precision branch May 25, 2021 15:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants