Update NavigationControl when min/maxZoom/Pitch change #11018
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rreusser
commented
Sep 14, 2021
| @@ -532,7 +532,7 @@ test(`Map#on mousedown can have default behavior prevented and still fire subseq | |||
| map.on('click', click); | |||
|
|
|||
| simulate.click(map.getCanvas()); | |||
| t.ok(click.callCount, 1); | |||
| t.equal(click.callCount, 1); | |||
There was a problem hiding this comment.
A drive-by fix for what appears to be a simple error.
avpeery
approved these changes
Sep 20, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See #11013
map.transform.minZoomandmap.transform.maxZoomaffect the appearance ofNavigationControl, butmap.setMinZoom()andmap.setMaxZoom()do not currently notify the control when these values have changed. This PR emits a sequence of dummy events (zoomstart,zoom,zoomend) when the values are set so that the control is updated correctly.The same goes for min/maxPitch.
Before (note that control does not update to mach minZoom until the map is zoomed):
After (control updates immediately when values are set):
Launch Checklist
@mapbox/map-design-team@mapbox/static-apisif this PR includes style spec API or visual changes@mapbox/gl-nativeif this PR includes shader changes or needs a native portmapbox-gl-jschangelog:<changelog>Update NavigationControl when min and max zoom are changed</changelog>