Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changes placeholder string to YOUR_MAPBOX_ACCESS_TOKEN in /mapbox-gl-js README.md and CONTRIBUTING.md #11113

Merged
merged 1 commit into from
Oct 13, 2021

Conversation

domlet
Copy link
Contributor

@domlet domlet commented Oct 12, 2021

Re: https://github.com/mapbox/documentation/issues/773

  • Changes token placeholder strings to YOUR_MAPBOX_ACCESS_TOKEN to consistify this placeholder string across all Mapbox docs.

@domlet domlet added docs 📜 skip changelog Used for PRs that do not need a changelog entry labels Oct 12, 2021
@domlet domlet requested review from HeyStenson and a team October 12, 2021 16:30
Copy link
Contributor

@HeyStenson HeyStenson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⭐ ☕

Copy link
Contributor

@SnailBones SnailBones left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@domlet
Copy link
Contributor Author

domlet commented Oct 13, 2021

Thanks for your 👀 @ansis and @SnailBones – I don't know how to resolve the test-render test failure here – may I leave this PR in your hands to merge? ty!

@ryanhamley
Copy link
Contributor

Looks like someone re-ran the render tests. Those failures are spurious and we're working on a fix for the flakiness in render tests. This is good to merge.

@ryanhamley ryanhamley merged commit ddaa1f7 into main Oct 13, 2021
@ryanhamley ryanhamley deleted the db-tokenstring branch October 13, 2021 18:14
katydecorah pushed a commit that referenced this pull request Oct 20, 2021
* main:
  Add touch pan blocker to gesture handling for touch devices (#11116)
  Address accessibility issues (#11064)
  add support for non-mercator projections (#11124)
  Image fallback expressions within paint properties (#11049)
  Replaces EPSG:4326 with OGC:CRS84 in GL JS `LngLat` doc (#11072)
  Add globe view support to heatmap shaders (#11120)
  Exclude flaky test (#11118)
  consistify YOUR_MAPBOX_ACCESS_TOKEN as placeholder string (#11113)
  Allow adding multiple layers to `map.on()` event handler (h/t @omerbn) (#11114)
  render-test-flakiness:clear worker storage (#11111)
  upgrade to supercluster v7.1.4, earcut v2.2.3, vt-pbf v3.1.3, geojson-rewind v0.5.1 (#11110)
  Added v1.13.2 changelog entry (#11108)
  One weird JSON.parse() trick (#11098)
  Fixed doc usage of map.getCenter (#11093)
  s̶y̶m̶b̶o̶l̶-̶c̶l̶i̶p̶ dynamic-filtering with `pitch` and `distance-from-camera` expressions (#10795)
  Update link to transpiling guide (#11096)
  Cherry pick 2.5.1 changelog (#11099)
  Fix an iOS15 issue where Safari tab bar interrupts panning (#11084)
  Fix conditional check for isFullscreen to accommodate Safari (#11086)
  Render tests for #11041 (#11070)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs 📜 skip changelog Used for PRs that do not need a changelog entry
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants