-
Notifications
You must be signed in to change notification settings - Fork 2.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Disable sky after maximum projection transition to mercator #11215
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
karimnaaji
added
the
skip changelog
Used for PRs that do not need a changelog entry
label
Nov 4, 2021
karimnaaji
force-pushed
the
karim/projection-sky
branch
from
November 4, 2021 00:32
69c7fae
to
617378d
Compare
arindam1993
approved these changes
Nov 4, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM otherwise
ansis
reviewed
Nov 4, 2021
karimnaaji
force-pushed
the
karim/projection-sky
branch
from
November 4, 2021 21:29
8666db7
to
2cbd8b8
Compare
ansis
approved these changes
Nov 4, 2021
ansis
pushed a commit
that referenced
this pull request
Nov 4, 2021
* Disable sky below maximum projection transition to mercator * Revert change * Better naming * Apply Ansis suggestion * Renaming
SnailBones
pushed a commit
that referenced
this pull request
Nov 5, 2021
* Disable sky below maximum projection transition to mercator * Revert change * Better naming * Apply Ansis suggestion * Renaming
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For non-mercator projection, this PR disables the sky layer after the end range of all projections that aren't mercator (as suggested in #11124 (comment)). This ensures that the sky is disabled before the end of sheer adjustment range where projections are set to mercator at high zoom levels.
Fixes #11207
The motivation is to give more thoughts on whether we could use it as a background fill for empty projection space. Some options that we should consider then:
Launch Checklist