Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Apply border-radius to control buttons #11423

Merged
merged 2 commits into from
Jan 21, 2022
Merged

Conversation

nagix
Copy link
Contributor

@nagix nagix commented Jan 20, 2022

This PR applies the correct border radius to control buttons with hover effects. Currently, it is only applied to the button with a focus.

Before:

Screen Shot 2022-01-20 at 1 45 28 PM Screen Shot 2022-01-20 at 1 45 37 PM

After:
Screen Shot 2022-01-20 at 1 43 13 PM Screen Shot 2022-01-20 at 1 44 50 PM

Launch Checklist

  • briefly describe the changes in this PR
  • include before/after visuals or gifs if this PR includes visual changes
  • manually test the debug page
  • apply changelog label ('bug', 'feature', 'docs', etc) or use the label 'skip changelog'
  • add an entry inside this element for inclusion in the mapbox-gl-js changelog: <changelog>Apply border-radius to control buttons</changelog>

@CLAassistant
Copy link

CLAassistant commented Jan 20, 2022

CLA assistant check
All committers have signed the CLA.

@ryanhamley
Copy link
Contributor

Under what conditions are you seeing this? Is it browser-specific? I can't reproduce the images above. #8520 should take care of this issue. This is what I see when I hover on the zoom buttons with a focus.

Screen Shot 2022-01-20 at 2 51 09 PM

@nagix
Copy link
Contributor Author

nagix commented Jan 21, 2022

Sorry, I didn't tell that in the images above, I intentionally increased the opacity of the hover effect to highlight the problem (using rgba(0, 0, 0, 0.5) instead of the original rgba(0, 0, 0, 0.05)). #8520 only fixed the shape with a focus, not hovering.

Copy link
Contributor

@ryanhamley ryanhamley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! Thanks for catching this.

@ryanhamley ryanhamley merged commit dbf0429 into mapbox:main Jan 21, 2022
@nagix nagix deleted the border-radius branch January 22, 2022 17:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants