Always wrap center coordinate to the range [-180, 180] #11448
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mpulkki-mapbox
force-pushed
the
mpulkki-fix-center-wrap
branch
from
011f099
to
de066d9
Compare
SnailBones
reviewed
Jan 31, 2022
| export function shortestAngle(a: number, b: number): number { | ||
| const diff = (b - a + 180) % 360 - 180; | ||
| return diff < -180 ? diff + 360 : diff; | ||
| } |
There was a problem hiding this comment.
Why is this function in util.js rather than inlined? Will it be used in other places? Or is this for ease of unit testing?
There was a problem hiding this comment.
Finding signed distance between two angles is a quite common and useful operation and a good candidate for having its own utility function. I couldn't find any good reasons for inlining it as the code path is not particularly hot and it's easier to test too. Would you like to see it inlined instead?
There was a problem hiding this comment.
Those all seem like good reasons. Great work @mpulkki-mapbox!
SnailBones
approved these changes
Feb 1, 2022
karimnaaji
approved these changes
Feb 1, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Panning the map doesn't automatically wrap the center point to the range [-180, 180]. User can move the map outside of the screen so that nothing gets rendered. This is possible as
center.wrap()is invoked only during easing of the fling gesture and not at all if user pans the map without leaving any inertia.gljs_center_wrap_bug.mp4
This PR fixes the issue by wrapping the center point in
transform._translateCameraConstrained(). Additionally thepointCoordinateimplementation for the globe view had to be updated to return non-wrapped coordinates to reflect the change.Fixes the following issue #11354 which was caused by mixed usage of wrapped and unwrapped coordinates in tile coverage computations.
Launch Checklist
mapbox-gl-jschangelog:<changelog>Fix map center not being wrapped properly after a drag gesture.</changelog>