Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cleanup popup close event listener #11540

Merged
merged 1 commit into from
Feb 21, 2022
Merged

Conversation

ryanhamley
Copy link
Contributor

Launch Checklist

  • briefly describe the changes in this PR
  • write tests for all new functionality
  • manually test the debug page
  • apply changelog label ('bug', 'feature', 'docs', etc) or use the label 'skip changelog'
  • add an entry inside this element for inclusion in the mapbox-gl-js changelog: <changelog>Cleanup Popup close event listeners</changelog>

@ryanhamley ryanhamley self-assigned this Feb 21, 2022
@ryanhamley ryanhamley merged commit 16756b3 into main Feb 21, 2022
@ryanhamley ryanhamley deleted the remove-popup-close-listener branch February 21, 2022 21:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Popup does not clean up event listeners if closeOnClick: true
2 participants