Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix camera under terrain when exaggeration changes #11578

Merged
merged 2 commits into from
Mar 11, 2022

Commits on Mar 9, 2022

  1. Fix camera under terrain when exaggeration changes

    Fixes issues when camera center would not change altitude if exaggeration changed and that camera could appear under terrain.
    
    Similar to #11461, the customer was affected (https://github.com/mapbox/mapbox-maps-android-internal/issues/850) by camera moved underground when animating exaggeration, increasing it from 0 in high altitude areas. In such an use case, we didn't adjust center and camera MSL altitude with exaggeration change.
    
    Extended usage of Transform._centerAltitudeValid to renamed _centerAltitudeValidForExaggeration: while data is not available, _centerAltitudeValidForExaggeration is 0. As soon as center elevation is available, new value for _centerAltitudeValidForExaggeration would trigger camera altitude adjustment in updateElevation.
    Aleksandar Stojiljković committed Mar 9, 2022
    Configuration menu
    Copy the full SHA
    4041e42 View commit details
    Browse the repository at this point in the history

Commits on Mar 11, 2022

  1. Fog demo: change exaggeration by pitch and zoom options

    Added exaggeration change on zoom (issue  #11044 is still open) and pitch (bug #11589) to fog demo.
    
    Fixes: #11589
    Aleksandar Stojiljković committed Mar 11, 2022
    Configuration menu
    Copy the full SHA
    adef123 View commit details
    Browse the repository at this point in the history