Add support for unit
in NumberFormat
#11839
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
NumberFormat
expression usesIntl.NumberFormat
and shares the same name. I casually assumed that this expressions is a simple wrapper and tried using it like this:But it didn't work. I would like to replace options object with an actual
Intl.NumberFormat
, but that would be a major update. I created this pull request thatunit
feature could be patched in with identical API ascurrency
:Launch Checklist
mapbox-gl-js
changelog:<changelog>Add unit option to number-format expression (h/t [varna](https://github.com/varna))</changelog>