Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade earcut to v2.2.4 #12061

Merged
merged 1 commit into from
Jul 7, 2022
Merged

Upgrade earcut to v2.2.4 #12061

merged 1 commit into from
Jul 7, 2022

Conversation

mourner
Copy link
Member

@mourner mourner commented Jul 5, 2022

Upgrade Earcut (library responsible for triangulating polygons) to v2.2.4, bringing performance improvements (up to ~15%) and a fix for a race condition that could cause an infinite loop.

Should improve tile loading times on low zoom levels, particularly the globe view, because half of the worker time is spent triangulating complex water body polygons (50% in earcut before the PR, 40% after).

  • briefly describe the changes in this PR
  • manually test the debug page
  • apply changelog label ('bug', 'feature', 'docs', etc) or use the label 'skip changelog'
  • add an entry inside this element for inclusion in the mapbox-gl-js changelog: <changelog>Improve tile loading performance on low zoom levels</changelog>

@mourner mourner requested a review from avpeery July 5, 2022 16:20
@mourner mourner added the performance ⚡ Speed, stability, CPU usage, memory usage, or power usage label Jul 5, 2022
Copy link
Contributor

@karimnaaji karimnaaji left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Looked at the changes from earcut, they look good to me.

@karimnaaji karimnaaji merged commit 6ac2c35 into main Jul 7, 2022
@karimnaaji karimnaaji deleted the earcut-2.2.4 branch July 7, 2022 15:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
performance ⚡ Speed, stability, CPU usage, memory usage, or power usage
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants