Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't fire mousemove when panning. #1555

Merged
merged 1 commit into from
Sep 25, 2015
Merged

Don't fire mousemove when panning. #1555

merged 1 commit into from
Sep 25, 2015

Conversation

mourner
Copy link
Member

@mourner mourner commented Sep 25, 2015

cc @jfirebaugh. Previously dragPan handler didn’t actually have an active property to track its state.

Also, dragRotate now becomes active when user actually starts dragging, not on mousedown.

@jfirebaugh
Copy link
Contributor

@mourner Do you recall the rationale for not firing mousemove events during drag gestures?

@mourner
Copy link
Member Author

mourner commented Feb 20, 2018

@jfirebaugh as far as I recall, mousemove was supposed to reflect mouse position changing its location on the map (rather than screen position). When we drag-pan the map, the mouse stays in the same location (it's the location that moves).

@jfirebaugh
Copy link
Contributor

...unless the map is up against the maximum Web Mercator latitude, or constrained by maxBounds, in which case the location does change.

I'm revisiting this due to #3290 and inclined to say that a map mousemove event should be fired for every DOM mousemove event, without exceptions.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants