fix featuresAt with overscaled tiles #2104
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ansis
force-pushed
the
fix-overscaled-features-at
branch
2 times, most recently
from
e8a0910
to
1de0a5e
Compare
| @@ -68,7 +72,8 @@ test('featuretree point query', function(t) { | |||
|
|
|||
| ft.query({ | |||
| source: "mapbox.mapbox-streets-v5", | |||
| scale: 724.0773439350247, | |||
| scale: 1.4142135624, | |||
| tileSize: 512, | |||
There was a problem hiding this comment.
was the scale wrong before?
There was a problem hiding this comment.
1.4142135624 * 512 = 724.0773439350247
I split the number into two numbers in #2052 because I thought it would be clearer and closer to how we treat conversions elsewhere.
There was a problem hiding this comment.
I understand. This is much more clear 👍
|
Can you add regression tests for the two bugs fixed? Otherwise this looks 🚢. |
ansis
force-pushed
the
fix-overscaled-features-at
branch
from
1de0a5e
to
25e5ed9
Compare
|
Added two tests for |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix #2103 and #2100 (comment)
👀 @lucaswoj