Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix bug preventing attribution from being displayed #2972

Merged
merged 2 commits into from
Aug 10, 2016
Merged

Conversation

lucaswoj
Copy link
Contributor

@lucaswoj lucaswoj commented Aug 10, 2016

A million gold stars to @tristen for noticing this 🌟 🌟 🌟 🌟 🌟 🌟 🌟 🌟 🌟 🌟 🌟 🌟

Since #2667 we have not been displaying any attribution on our maps! Fortunately this PR has not gone out in a release yet. We desperately need to tackle #1550.

This PR fixes the bug by setting an attribution property on SourceCache.

cc @anandthakker @tristen @mourner @mollymerp

Checklist

@mollymerp
Copy link
Contributor

yipes! great catch @tristen !! agreed on UI tests.

talked to @scothis and he says they use selenium automated web driver to test studio UI interactions. probably worth exploring for gl-js although he mentioned it might be difficult without DOM elements to interact with.

@anandthakker
Copy link
Contributor

Yikes 😳 nice save @tristen . So glad this didn't get out into a release; 👍 x 💯 on DOM/UI tests.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants