Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make attribution control responsive. #3783

Merged
merged 3 commits into from
Dec 15, 2016

Conversation

lennerd
Copy link
Contributor

@lennerd lennerd commented Dec 12, 2016

This PR adds responsiveness to AttributionControl by adding a compact version. This is very similar to the mapbox.js API and can also be activated by passing compact: true as an option to the AttributionControl.

var map = new mapboxgl.Map({ attributionControl: false })
    .addControl(new mapboxgl.AttributionControl({
        compact: true
    }));

Fixes: #3284

  • briefly describe the changes in this PR
  • manually test the debug page
  • gather feedback for the given changes
  • write tests for all new functionalities
  • document any changes to public APIs

Happy to hear your feedback.

@lennerd
Copy link
Contributor Author

lennerd commented Dec 12, 2016

#3284 (comment):

@lennerd a PR would be very welcome! The label just means that an equivalent functionality is already there in Mapbox GL Native, and we just need to match it in GL JS.

Is this meant to match feature- or also layout-wise?

@mollymerp
Copy link
Contributor

Thank you for this PR @lennerd!! It is working as expected when I run it locally.

cc @tristen for design 👀

@lennerd
Copy link
Contributor Author

lennerd commented Dec 13, 2016

Any more feedback? Otherwise I would work on some simple tests, add some documentation and rebase the PR.

@tristen
Copy link
Member

tristen commented Dec 13, 2016

@lennerd Design wise this looks great!

simple tests, add some documentation and rebase the PR.

👍

@lennerd lennerd force-pushed the enhancement/responsive-attrib branch from 6d855fb to 29a7b2b Compare December 14, 2016 08:11
@lennerd
Copy link
Contributor Author

lennerd commented Dec 14, 2016

Docs now reflect the new attribution control option, tests are running smoothly, PR is rebased.

Anything more I can do?

@lucaswoj
Copy link
Contributor

Tests passing locally 🚢

@lucaswoj lucaswoj merged commit cefab08 into mapbox:master Dec 15, 2016
@lennerd lennerd deleted the enhancement/responsive-attrib branch December 15, 2016 08:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants