Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

clean up matrix creation #3790

Merged
merged 4 commits into from
Dec 14, 2016
Merged

clean up matrix creation #3790

merged 4 commits into from
Dec 14, 2016

Commits on Dec 14, 2016

  1. fix text blurriness at different FOVs 

    This replaces a hardcoded shader approximation with a more correct,
FOV-dependent one.

`gl_Position.w - 0.5`
is replaced with
`gl_Position.w / tan(fov)`

The `/ tan(fov)` is handled by multiplying `1 / tan(fov)` into `u_gamma`
outside the shader.

I think `- 0.5` was just chosen as something that looked right for the
default fov.
    @ansis
    ansis committed Dec 14, 2016
    Configuration menu
    Copy the full SHA
    c52a096 View commit details
    Browse the repository at this point in the history

  2. replace altitude with fov 

    `altitude` was a terribly-named variable that was used to indirectly
control the fov. This should eliminate some confusion.

`altitude` was equivalent to `cameraToCenterDistance / height`
    @ansis
    ansis committed Dec 14, 2016
    Configuration menu
    Copy the full SHA
    eb6c659 View commit details
    Browse the repository at this point in the history

  3. fix matrix z range and remove hack 

    This should fix the issue behind #2270 and remove the need for the hack
added in #3740.
    @ansis
    ansis committed Dec 14, 2016
    Configuration menu
    Copy the full SHA
    0b5520f View commit details
    Browse the repository at this point in the history

  4. clearer pitched line antialiasing 

    Project the extrusion and compare it's projected pixel length with the
actual pixel length and adjust antialiasing accordingly.

The previous approach calculated the adjustment much more indirectly and
had no intuitive explanation.
    @ansis
    ansis committed Dec 14, 2016
    Configuration menu
    Copy the full SHA
    ef5582d View commit details
    Browse the repository at this point in the history