Pause tile reloads when worker layer update is pending #4893
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This isn't pretty, but (a) it can hold us over until we can take on larger refactors, and (b) it's probably good to wire in this dependency--i.e. the need for batched-updated processing to control tile loading--before those refactors, so that we have to take it into account when we do them. |
|
Unfortunately this doesn't fix the issue. I'll add the test file to this branch so you can see. |
|
Shoot, my unit test was bogus. Amended / force-pushed and I think it should now be fixed. (Note: temporarily leaving the test file in for verification despite lint errors.) |
jfirebaugh
approved these changes
Jun 28, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #4738