Draw debug tiles for source with largest maxZoom #4990
Conversation
asheemmamoowala
force-pushed
the
4830-debug-tiles
branch
2 times, most recently
from
97eb1cb
to
3c660d3
Compare
|
I did the single source debug intentionally at some point, because it can get very confusing visually when you have multiple sources drawn at the same time (especially if they have different tile sizes etc.). Would it be better to keep the logic but just make sure we use a source that's visible on the current zoom (rather than just the first source)? |
|
If we have multiple sources with difference tile sizes, this same problem would arise if we pick just one source, some sources might be using smaller tiles, and we may not be drawing those even if they are visible at the current zoom level. |
asheemmamoowala
force-pushed
the
4830-debug-tiles
branch
from
3c660d3
to
519ca77
Compare
asheemmamoowala
changed the title
|
@mourner - I've changes this to draw tiles for just a single source -> the visible source with the largest |
src/source/tile_coord.js
Outdated
| return `${this.z}/${this.x}/${this.y}`; | ||
| toString(sourceMaxZoom: number | void) { | ||
| if (sourceMaxZoom && sourceMaxZoom < this.z) { | ||
| return `${sourceMaxZoom}/${this.x}/${this.y} => ${this.z}`; |
There was a problem hiding this comment.
🤔 is there any way I can talk you into writing a render test that shows this?
asheemmamoowala
force-pushed
the
4830-debug-tiles
branch
from
519ca77
to
e39c945
Compare
ryanhamley
force-pushed
the
4830-debug-tiles
branch
from
6ba7988
to
016d95c
Compare
Closes #4830
Closes #5535