Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add clamping for halo-width values to avoid ugly boxes. #7441

Closed
wants to merge 6 commits into from
Closed

Add clamping for halo-width values to avoid ugly boxes. #7441

wants to merge 6 commits into from

Commits on Oct 18, 2018

  1. Add clamping for halo-width values to avoid ugly boxes. 

    Fixes issue #7204 (or at least makes it less dramatic)
Add explanatory warning to `icon-halo-width` in v8.json.
    @ChrisLoer
    ChrisLoer committed Oct 18, 2018
    Configuration menu
    Copy the full SHA
    04823e8 View commit details
    Browse the repository at this point in the history

  2. Render test for icon-halo-width clamping.

    @ChrisLoer
    ChrisLoer committed Oct 18, 2018
    Configuration menu
    Copy the full SHA
    88b775c View commit details
    Browse the repository at this point in the history

  3. Update text-halo-width test to reflect new clamping behavior.

    @ChrisLoer
    ChrisLoer committed Oct 18, 2018
    Configuration menu
    Copy the full SHA
    de06982 View commit details
    Browse the repository at this point in the history

  4. Clamp MAX_OUTSIDE_DISTANCE as 1/256 instead of 0. 

    Using "0" wasn't consistent across different GL implementations.
    @ChrisLoer
    ChrisLoer committed Oct 18, 2018
    Configuration menu
    Copy the full SHA
    4621fc1 View commit details
    Browse the repository at this point in the history

  5. Update text-halo-blur tests to match new halo clamping.

    @ChrisLoer
    ChrisLoer committed Oct 18, 2018
    Configuration menu
    Copy the full SHA
    a55a589 View commit details
    Browse the repository at this point in the history

  6. Allow halo_blur "inside" distance to go greater than 1: 

    Clamping the upper value could change the center of the smoothstep function even when the halo was entirely within the maximum "outside" distance (and the outside distance is the part that would be visible).
    @ChrisLoer
    ChrisLoer committed Oct 18, 2018
    Configuration menu
    Copy the full SHA
    2c90315 View commit details
    Browse the repository at this point in the history