Prevent calls to getLayoutProperty from causing fatal error when layer doesn't exist #7539
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ryanhamley
force-pushed
the
getlayoutproperty-error-handling
branch
from
d06a39a
to
74775c1
Compare
mollymerp
reviewed
Nov 1, 2018
added 3 commits
November 1, 2018 15:23
ryanhamley
force-pushed
the
getlayoutproperty-error-handling
branch
from
74775c1
to
2d0b712
Compare
|
Test added @mollymerp |
mollymerp
approved these changes
Nov 1, 2018
This reverts commit 2d0b712.
|
I pulled the linter fixes out to #7541 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #7537
Launch Checklist
map.getLayoutProperty()for a layer that does not exist, a fatal error would fire.setLayoutProperty()fires a warning error to handle this situation. This PR updatesgetLayoutPropertyto do the same thing.layerargument tolayerIdto matchsetLayoutProperty